|
@@ -12,10 +12,9 @@ import (
|
|
|
"github.com/gojuno/minimock/v3"
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
|
|
- API "git.dmitriygnatenko.ru/dima/homethings/internal/api/v1"
|
|
|
"git.dmitriygnatenko.ru/dima/homethings/internal/api/v1/thing/mocks"
|
|
|
"git.dmitriygnatenko.ru/dima/homethings/internal/dto"
|
|
|
- "git.dmitriygnatenko.ru/dima/homethings/internal/helpers"
|
|
|
+ "git.dmitriygnatenko.ru/dima/homethings/internal/helpers/test"
|
|
|
"git.dmitriygnatenko.ru/dima/homethings/internal/models"
|
|
|
)
|
|
|
|
|
@@ -28,14 +27,18 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
}
|
|
|
|
|
|
var (
|
|
|
- thingID = gofakeit.Number(1, 1000)
|
|
|
- imageID = gofakeit.Number(1, 1000)
|
|
|
+ thingID = uint64(gofakeit.Number(1, 1000))
|
|
|
+ imageID = uint64(gofakeit.Number(1, 1000))
|
|
|
imageURL = gofakeit.URL()
|
|
|
testError = gofakeit.Error()
|
|
|
|
|
|
+ txMockFunc = func(ctx context.Context, f func(ctx context.Context) error) error {
|
|
|
+ return f(ctx)
|
|
|
+ }
|
|
|
+
|
|
|
correctReq = req{
|
|
|
method: fiber.MethodDelete,
|
|
|
- route: "/v1/things/" + strconv.Itoa(thingID),
|
|
|
+ route: "/v1/things/" + strconv.FormatUint(thingID, 10),
|
|
|
}
|
|
|
|
|
|
repoImagesRes = []models.Image{
|
|
@@ -51,6 +54,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
req req
|
|
|
resCode int
|
|
|
resBody interface{}
|
|
|
+ tmMock func(mc *minimock.Controller) TransactionManager
|
|
|
thingRepoMock func(mc *minimock.Controller) ThingRepository
|
|
|
placeThingRepoMock func(mc *minimock.Controller) PlaceThingRepository
|
|
|
thingImageRepoMock func(mc *minimock.Controller) ThingImageRepository
|
|
@@ -65,6 +69,9 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
route: "/v1/things/" + gofakeit.Word(),
|
|
|
},
|
|
|
resCode: fiber.StatusBadRequest,
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ return mocks.NewTransactionManagerMock(mc)
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
return mocks.NewThingRepositoryMock(mc)
|
|
|
},
|
|
@@ -88,10 +95,13 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
name: "negative case - bad request (thing not found)",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusBadRequest,
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ return mocks.NewTransactionManagerMock(mc)
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, sql.ErrNoRows)
|
|
|
|
|
@@ -117,10 +127,13 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
name: "negative case - repository error (get thing)",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusInternalServerError,
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ return mocks.NewTransactionManagerMock(mc)
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, testError)
|
|
|
|
|
@@ -143,55 +156,27 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
},
|
|
|
},
|
|
|
{
|
|
|
- name: "negative case - repository error (begin tx)",
|
|
|
+ name: "negative case - repository error (delete place thing)",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusInternalServerError,
|
|
|
- thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
- mock := mocks.NewThingRepositoryMock(mc)
|
|
|
-
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
- assert.Equal(mc, thingID, id)
|
|
|
- }).Return(nil, nil)
|
|
|
-
|
|
|
- mock.BeginTxMock.Return(nil, testError)
|
|
|
-
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ mock := mocks.NewTransactionManagerMock(mc)
|
|
|
+ mock.ReadCommittedMock.Set(txMockFunc)
|
|
|
return mock
|
|
|
},
|
|
|
- placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
- return mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
- },
|
|
|
- thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
- return mocks.NewThingImageRepositoryMock(mc)
|
|
|
- },
|
|
|
- thingTagRepoMock: func(mc *minimock.Controller) ThingTagRepository {
|
|
|
- return mocks.NewThingTagRepositoryMock(mc)
|
|
|
- },
|
|
|
- thingNotificationRepoMock: func(mc *minimock.Controller) ThingNotificationRepository {
|
|
|
- return mocks.NewThingNotificationRepositoryMock(mc)
|
|
|
- },
|
|
|
- fileRepoMock: func(mc *minimock.Controller) FileRepository {
|
|
|
- return mocks.NewFileRepositoryMock(mc)
|
|
|
- },
|
|
|
- },
|
|
|
- {
|
|
|
- name: "negative case - repository error (delete place thing)",
|
|
|
- req: correctReq,
|
|
|
- resCode: fiber.StatusInternalServerError,
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, nil)
|
|
|
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
return mock
|
|
|
},
|
|
|
placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteThingMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(testError)
|
|
|
|
|
@@ -214,21 +199,24 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
name: "negative case - repository error (get images)",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusInternalServerError,
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ mock := mocks.NewTransactionManagerMock(mc)
|
|
|
+ mock.ReadCommittedMock.Set(txMockFunc)
|
|
|
+ return mock
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, nil)
|
|
|
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
return mock
|
|
|
},
|
|
|
placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteThingMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -237,7 +225,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
mock := mocks.NewThingImageRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetByThingIDMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, testError)
|
|
|
|
|
@@ -257,21 +245,24 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
name: "negative case - repository error (delete images)",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusInternalServerError,
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ mock := mocks.NewTransactionManagerMock(mc)
|
|
|
+ mock.ReadCommittedMock.Set(txMockFunc)
|
|
|
+ return mock
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, nil)
|
|
|
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
return mock
|
|
|
},
|
|
|
placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteThingMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -280,11 +271,11 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
mock := mocks.NewThingImageRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetByThingIDMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(repoImagesRes, nil)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, imageID, id)
|
|
|
}).Return(testError)
|
|
|
|
|
@@ -304,21 +295,24 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
name: "negative case - repository error (delete thing tags)",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusInternalServerError,
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ mock := mocks.NewTransactionManagerMock(mc)
|
|
|
+ mock.ReadCommittedMock.Set(txMockFunc)
|
|
|
+ return mock
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, nil)
|
|
|
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
return mock
|
|
|
},
|
|
|
placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteThingMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -327,11 +321,11 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
mock := mocks.NewThingImageRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetByThingIDMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(repoImagesRes, nil)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, imageID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -340,7 +334,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingTagRepoMock: func(mc *minimock.Controller) ThingTagRepository {
|
|
|
mock := mocks.NewThingTagRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(testError)
|
|
|
|
|
@@ -357,21 +351,24 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
name: "negative case - repository error (delete notification)",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusInternalServerError,
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ mock := mocks.NewTransactionManagerMock(mc)
|
|
|
+ mock.ReadCommittedMock.Set(txMockFunc)
|
|
|
+ return mock
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, nil)
|
|
|
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
return mock
|
|
|
},
|
|
|
placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteThingMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -380,11 +377,11 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
mock := mocks.NewThingImageRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetByThingIDMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(repoImagesRes, nil)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, imageID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -393,7 +390,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingTagRepoMock: func(mc *minimock.Controller) ThingTagRepository {
|
|
|
mock := mocks.NewThingTagRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -402,7 +399,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingNotificationRepoMock: func(mc *minimock.Controller) ThingNotificationRepository {
|
|
|
mock := mocks.NewThingNotificationRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(testError)
|
|
|
|
|
@@ -416,90 +413,28 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
name: "negative case - repository error (delete thing)",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusInternalServerError,
|
|
|
- thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
- mock := mocks.NewThingRepositoryMock(mc)
|
|
|
-
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
- assert.Equal(mc, thingID, id)
|
|
|
- }).Return(nil, nil)
|
|
|
-
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
- assert.Equal(mc, thingID, id)
|
|
|
- }).Return(testError)
|
|
|
-
|
|
|
- return mock
|
|
|
- },
|
|
|
- placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
- mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
-
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
- assert.Equal(mc, thingID, id)
|
|
|
- }).Return(nil)
|
|
|
-
|
|
|
- return mock
|
|
|
- },
|
|
|
- thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
- mock := mocks.NewThingImageRepositoryMock(mc)
|
|
|
-
|
|
|
- mock.GetByThingIDMock.Inspect(func(ctx context.Context, id int) {
|
|
|
- assert.Equal(mc, thingID, id)
|
|
|
- }).Return(repoImagesRes, nil)
|
|
|
-
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
- assert.Equal(mc, imageID, id)
|
|
|
- }).Return(nil)
|
|
|
-
|
|
|
- return mock
|
|
|
- },
|
|
|
- thingTagRepoMock: func(mc *minimock.Controller) ThingTagRepository {
|
|
|
- mock := mocks.NewThingTagRepositoryMock(mc)
|
|
|
-
|
|
|
- mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
- assert.Equal(mc, thingID, id)
|
|
|
- }).Return(nil)
|
|
|
-
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ mock := mocks.NewTransactionManagerMock(mc)
|
|
|
+ mock.ReadCommittedMock.Set(txMockFunc)
|
|
|
return mock
|
|
|
},
|
|
|
- thingNotificationRepoMock: func(mc *minimock.Controller) ThingNotificationRepository {
|
|
|
- mock := mocks.NewThingNotificationRepositoryMock(mc)
|
|
|
-
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
- assert.Equal(mc, thingID, id)
|
|
|
- }).Return(nil)
|
|
|
-
|
|
|
- return mock
|
|
|
- },
|
|
|
- fileRepoMock: func(mc *minimock.Controller) FileRepository {
|
|
|
- return mocks.NewFileRepositoryMock(mc)
|
|
|
- },
|
|
|
- },
|
|
|
- {
|
|
|
- name: "negative case - repository error (commit tx)",
|
|
|
- req: correctReq,
|
|
|
- resCode: fiber.StatusInternalServerError,
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, nil)
|
|
|
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
- }).Return(nil)
|
|
|
-
|
|
|
- mock.CommitTxMock.Return(testError)
|
|
|
+ }).Return(testError)
|
|
|
|
|
|
return mock
|
|
|
},
|
|
|
placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteThingMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -508,11 +443,11 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
mock := mocks.NewThingImageRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetByThingIDMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(repoImagesRes, nil)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, imageID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -521,7 +456,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingTagRepoMock: func(mc *minimock.Controller) ThingTagRepository {
|
|
|
mock := mocks.NewThingTagRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -530,7 +465,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingNotificationRepoMock: func(mc *minimock.Controller) ThingNotificationRepository {
|
|
|
mock := mocks.NewThingNotificationRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -544,27 +479,28 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
name: "negative case - file delete error",
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusInternalServerError,
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ mock := mocks.NewTransactionManagerMock(mc)
|
|
|
+ mock.ReadCommittedMock.Set(txMockFunc)
|
|
|
+ return mock
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, nil)
|
|
|
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
|
- mock.CommitTxMock.Return(nil)
|
|
|
-
|
|
|
return mock
|
|
|
},
|
|
|
placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteThingMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -573,11 +509,11 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
mock := mocks.NewThingImageRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetByThingIDMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(repoImagesRes, nil)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, imageID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -586,7 +522,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingTagRepoMock: func(mc *minimock.Controller) ThingTagRepository {
|
|
|
mock := mocks.NewThingTagRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -595,7 +531,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingNotificationRepoMock: func(mc *minimock.Controller) ThingNotificationRepository {
|
|
|
mock := mocks.NewThingNotificationRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -612,27 +548,28 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
req: correctReq,
|
|
|
resCode: fiber.StatusOK,
|
|
|
resBody: dto.EmptyResponse{},
|
|
|
+ tmMock: func(mc *minimock.Controller) TransactionManager {
|
|
|
+ mock := mocks.NewTransactionManagerMock(mc)
|
|
|
+ mock.ReadCommittedMock.Set(txMockFunc)
|
|
|
+ return mock
|
|
|
+ },
|
|
|
thingRepoMock: func(mc *minimock.Controller) ThingRepository {
|
|
|
mock := mocks.NewThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil, nil)
|
|
|
|
|
|
- mock.BeginTxMock.Return(nil, nil)
|
|
|
-
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
|
- mock.CommitTxMock.Return(nil)
|
|
|
-
|
|
|
return mock
|
|
|
},
|
|
|
placeThingRepoMock: func(mc *minimock.Controller) PlaceThingRepository {
|
|
|
mock := mocks.NewPlaceThingRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteThingMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteThingMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -641,11 +578,11 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingImageRepoMock: func(mc *minimock.Controller) ThingImageRepository {
|
|
|
mock := mocks.NewThingImageRepositoryMock(mc)
|
|
|
|
|
|
- mock.GetByThingIDMock.Inspect(func(ctx context.Context, id int) {
|
|
|
+ mock.GetByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(repoImagesRes, nil)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, imageID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -654,7 +591,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingTagRepoMock: func(mc *minimock.Controller) ThingTagRepository {
|
|
|
mock := mocks.NewThingTagRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteByThingIDMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -663,7 +600,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
thingNotificationRepoMock: func(mc *minimock.Controller) ThingNotificationRepository {
|
|
|
mock := mocks.NewThingNotificationRepositoryMock(mc)
|
|
|
|
|
|
- mock.DeleteMock.Inspect(func(ctx context.Context, id int, tx *sql.Tx) {
|
|
|
+ mock.DeleteMock.Inspect(func(ctx context.Context, id uint64) {
|
|
|
assert.Equal(mc, thingID, id)
|
|
|
}).Return(nil)
|
|
|
|
|
@@ -685,6 +622,7 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
fiberApp := fiber.New()
|
|
|
|
|
|
fiberApp.Delete("/v1/things/:thingId", DeleteThingHandler(
|
|
|
+ tt.tmMock(mc),
|
|
|
tt.thingRepoMock(mc),
|
|
|
tt.thingTagRepoMock(mc),
|
|
|
tt.placeThingRepoMock(mc),
|
|
@@ -693,10 +631,13 @@ func TestDeleteThingHandler(t *testing.T) {
|
|
|
tt.fileRepoMock(mc),
|
|
|
))
|
|
|
|
|
|
- fiberRes, _ := fiberApp.Test(httptest.NewRequest(tt.req.method, tt.req.route, nil), API.DefaultTestTimeOut)
|
|
|
+ fiberRes, _ := fiberApp.Test(
|
|
|
+ httptest.NewRequest(tt.req.method, tt.req.route, nil),
|
|
|
+ test.TestTimeout,
|
|
|
+ )
|
|
|
assert.Equal(t, tt.resCode, fiberRes.StatusCode)
|
|
|
if tt.resBody != nil {
|
|
|
- assert.Equal(t, helpers.MarshalResponse(tt.resBody), helpers.ConvertBodyToString(fiberRes.Body))
|
|
|
+ assert.Equal(t, test.MarshalResponse(tt.resBody), test.ConvertBodyToString(fiberRes.Body))
|
|
|
}
|
|
|
})
|
|
|
}
|